linux-kernel - Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120407013927.AC7163E21DC@localhost>
Date:	Fri, 06 Apr 2012 18:39:27 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	"Cousson, Benoit" <b-cousson@...com>,
	Sourav Poddar <sourav.poddar@...com>
Cc:	devicetree-discuss@...ts.ozlabs.org, linux-kernel@...r.kernel.org,
	Rob Herring <rob.herring@...xeda.com>,
	Felipe Balbi <balbi@...com>, linux-input@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/2] arm/dts: omap4-sdp: Add keypad data

On Wed, 4 Apr 2012 15:51:38 +0200, "Cousson, Benoit" <b-cousson@...com> wrote:
> On 4/4/2012 3:30 PM, Sourav Poddar wrote:
> > This patch add keypad data node in omap4 device tree
> > file.
> 
> Nit #2: Never write "this patch" in a patch changelog... Because at some 
> point it will become a commit in a GIT tree.
> 
> I think AKPM wrote something on that.

Whatever.  I'm won't *ever* get worked up about something like that if
the changelog is otherwise well written.  What I do want to see is a
description of what the patch does, why it is needed, and how it was
tested.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/