linux-kernel - Re: [PATCH v2 13/13] ARM: at91: dt: remove unit-address part for memory nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120407014330.B6D4E3E22DF@localhost>
Date:	Fri, 06 Apr 2012 18:43:30 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Olof Johansson <olof@...om.net>,
	Nicolas Ferre <nicolas.ferre@...el.com>
Cc:	arnd@...db.de, devicetree-discuss@...ts.ozlabs.org,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	ludovic.desroches@...el.com, plagnioj@...osoft.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2 13/13] ARM: at91: dt: remove unit-address part for memory nodes

On Wed, 4 Apr 2012 12:17:54 -0700, Olof Johansson <olof@...om.net> wrote:
> On Tue, Apr 03, 2012 at 09:32:57AM +0200, Nicolas Ferre wrote:
> > From: Ludovic Desroches <ludovic.desroches@...el.com>
> > 
> > Having a unit-address different from 0 causes bad memory node detection
> > during early_init_dt_scan_memory.
> 
> Sounds like a bug in the generic code to me? But specifying a unit
> address on a non-ambiguous device node isn't necessary anyway, so this
> patch is still a reasonable thing to do.

It's actually a 'feature' of the way we're including skeleton.dtsi.
skeleton.dtsi has already set the node name, so if the next file
doesn't use exactly the same node name then the .dtb ends up with two
memory nodes, which is really bad.

It real problem is the dtc tooling.

g.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/