linux-kernel - Re: [PATCH] gpio: Fix uninitialized variable bit in adp5588_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 06 Apr 2012 15:48:11 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	Axel Lin <axel.lin@...il.com>, linux-kernel@...r.kernel.org
Cc:	Michael Hennerich <hennerich@...ckfin.uclinux.org>,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [PATCH] gpio: Fix uninitialized variable bit in adp5588_irq_handler

On Fri, 06 Apr 2012 20:37:43 +0800, Axel Lin <axel.lin@...il.com> wrote:
> The variable 'bit' is uninitialized in the first iteration of for loop. Fix it.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied, and will merge for v3.4.  THanks.

g.

> ---
>  drivers/gpio/gpio-adp5588.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-adp5588.c b/drivers/gpio/gpio-adp5588.c
> index 9ad1703..ae5d7f1 100644
> --- a/drivers/gpio/gpio-adp5588.c
> +++ b/drivers/gpio/gpio-adp5588.c
> @@ -252,7 +252,7 @@ static irqreturn_t adp5588_irq_handler(int irq, void *devid)
>  		if (ret < 0)
>  			memset(dev->irq_stat, 0, ARRAY_SIZE(dev->irq_stat));
>  
> -		for (bank = 0; bank <= ADP5588_BANK(ADP5588_MAXGPIO);
> +		for (bank = 0, bit = 0; bank <= ADP5588_BANK(ADP5588_MAXGPIO);
>  			bank++, bit = 0) {
>  			pending = dev->irq_stat[bank] & dev->irq_mask[bank];
>  
> -- 
> 1.7.5.4
> 
> 
> 

-- 
Grant Likely, B.Sc, P.Eng.
Secret Lab Technologies,Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/