linux-kernel - Re: [PATCH v2] avr32: fix nop compile fails from system.h split up

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120407101039.GA10112@samfundet.no>
Date:	Sat, 7 Apr 2012 12:10:39 +0200
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Paul Gortmaker <paul.gortmaker@...driver.com>
Cc:	dhowells@...hat.com, torvalds@...ux-foundation.org,
	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	Haavard Skinnemoen <hskinnemoen@...il.com>
Subject: Re: [PATCH v2] avr32: fix nop compile fails from system.h split up

Around Tue 03 Apr 2012 19:14:04 -0400 or thereabout, Paul Gortmaker wrote:
> To fix:
> 
>   In file included from kernel/exit.c:61:
>   arch/avr32/include/asm/mmu_context.h: In function 'enable_mmu':
>   arch/avr32/include/asm/mmu_context.h:135: error: implicit
>   declaration of function 'nop'
> 
> It needs an include of the new file created in:
> 
> commit ae473946586680b01c13975a3b674de23ad7c93e
> 
>     "Disintegrate asm/system.h for AVR32"
> 
> But since that file only contains "nop", and since other
> arch already have precedent of putting nop in asm/barrier.h
> we should just delete the new file and put nop in barrier.h

Sounds fine by me, thanks for the fix.

> Suggested-by: David Howells <dhowells@...hat.com>
> Cc: Haavard Skinnemoen <hskinnemoen@...il.com>
> Cc: Hans-Christian Egtvedt <egtvedt@...fundet.no>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>

Acked-by: Hans-Christian Egtvedt <egtvedt@...fundet.no>

<snipp diff>

-- 
mvh
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/