linux-kernel - Re: [PATCH] android: make persistent_ram based drivers depend on HAVE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 8 Apr 2012 10:43:48 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Colin Cross <ccross@...roid.com>
Cc:	linux-kernel@...r.kernel.org, linux-next@...r.kernel.org,
	John Stultz <john.stultz@...aro.org>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Android Kernel Team <kernel-team@...roid.com>,
	gregkh@...uxfoundation.org,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] android: make persistent_ram based drivers depend on HAVE_MEMBLOCK

On Wed, Mar 21, 2012 at 18:18, Colin Cross <ccross@...roid.com> wrote:
> m68k doesn't have memblock_reserve, which causes a build failure
> with allmodconfig.  Make PERSISTENT_RAM and RAM_CONSOLE depend on
> HAVE_MEMBLOCK.
>
> Reported-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Reported-by: Paul Gortmaker <paul.gortmaker@...driver.com>
> Signed-off-by: Colin Cross <ccross@...roid.com>

Acked-by: Geert Uytterhoeven <geert@...ux-m68k.org>

> ---
>  drivers/staging/android/Kconfig |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> I can't test on m68k, but this disables the options if I remove
> HAVE_MEMBLOCK from arm.
>
> diff --git a/drivers/staging/android/Kconfig b/drivers/staging/android/Kconfig
> index 08a3b11..eb1dee2 100644
> --- a/drivers/staging/android/Kconfig
> +++ b/drivers/staging/android/Kconfig
> @@ -27,13 +27,14 @@ config ANDROID_LOGGER
>
>  config ANDROID_PERSISTENT_RAM
>        bool
> +       depends on HAVE_MEMBLOCK
>        select REED_SOLOMON
>        select REED_SOLOMON_ENC8
>        select REED_SOLOMON_DEC8
>
>  config ANDROID_RAM_CONSOLE
>        bool "Android RAM buffer console"
> -       depends on !S390 && !UML
> +       depends on !S390 && !UML && HAVE_MEMBLOCK
>        select ANDROID_PERSISTENT_RAM
>        default n

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/