linux-kernel - Re: [PATCH] leds: simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1333981564.2871.1.camel@lorien2>
Date:	Mon, 09 Apr 2012 08:26:04 -0600
From:	Shuah Khan <shuahkhan@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	shuahkhan@...il.com, Andrew Morton <akpm@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>, rpurdie@...ux.intel.com
Subject: Re: [PATCH] leds: simple_strtoul-cleanup

On Sun, 2012-04-08 at 13:20 -0700, Joe Perches wrote:
> On Sun, 2012-04-08 at 14:13 -0600, Shuah Khan wrote:
> > led-class.c and ledtri-timer.c still use simple_strtoul(). 
> > Change leds to use kstrtoul() instead of obsolete simple_strtoul().
> []
> > @@ -44,23 +44,19 @@ static ssize_t led_brightness_store(struct device *dev,
> >  		struct device_attribute *attr, const char *buf, size_t size)
> [] 
> > diff --git a/drivers/leds/ledtrig-timer.c b/drivers/leds/ledtrig-timer.c
> > @@ -31,21 +31,18 @@ static ssize_t led_delay_on_store(struct device *dev,
> >  		struct device_attribute *attr, const char *buf, size_t size)
> []
> >  static ssize_t led_delay_off_show(struct device *dev,
> []
> > +out:
> > +	return size;
> 
> These now don't return -EINVAL, is that a problem
> for any caller?

I looked at the other _store() interfaces in leds - there is no
consistent EINVAL return. However, it would be an easy change to make to
have these return EINVAL in case of error like they used to. I can send
an updated patch.

-- Shuah

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/