| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.LNX.2.00.1204092229370.13925@swampdragon.chaosbits.net> Date: Mon, 9 Apr 2012 22:51:41 +0200 (CEST) From: Jesper Juhl <jj@...osbits.net> To: linux-kernel@...r.kernel.org cc: trivial@...nel.org, linux-scsi@...r.kernel.org, "James E.J. Bottomley" <JBottomley@...allels.com>, linux-driver@...gic.com, Andrew Vasquez <andrew.vasquez@...gic.com> Subject: [PATCH 19/26] [SCSI] qla2xxx: Remove redundant NULL check before release_firmware() call. release_firmware() checks for NULL pointers internally so checking before calling it is redundant. Signed-off-by: Jesper Juhl <jj@...osbits.net> --- drivers/scsi/qla2xxx/qla_os.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c index a2f9992..91b6fe6 100644 --- a/drivers/scsi/qla2xxx/qla_os.c +++ b/drivers/scsi/qla2xxx/qla_os.c @@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void) mutex_lock(&qla_fw_lock); for (idx = 0; idx < FW_BLOBS; idx++) - if (qla_fw_blobs[idx].fw) - release_firmware(qla_fw_blobs[idx].fw); + release_firmware(qla_fw_blobs[idx].fw); mutex_unlock(&qla_fw_lock); } -- 1.7.10 -- Jesper Juhl <jj@...osbits.net> http://www.chaosbits.net/ Don't top-post http://www.catb.org/jargon/html/T/top-post.html Plain text mails only, please. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists