linux-kernel - Re: [PATCH 19/26] [SCSI] qla2xxx: Remove redundant NULL check before release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.WNT.2.00.1204100821500.5072@N5102REMCQXM4BS.qlogic.org>
Date:	Tue, 10 Apr 2012 08:22:29 -0400
From:	Chad Dupuis <chad.dupuis@...gic.com>
To:	Jesper Juhl <jj@...osbits.net>
CC:	linux-kernel <linux-kernel@...r.kernel.org>,
	"trivial@...nel.org" <trivial@...nel.org>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Dept-Eng Linux Driver <Linux-Driver@...gic.com>,
	Andrew Vasquez <andrew.vasquez@...gic.com>
Subject: Re: [PATCH 19/26] [SCSI] qla2xxx: Remove redundant NULL check before
 release_firmware() call.



On Mon, 9 Apr 2012, Jesper Juhl wrote:

> release_firmware() checks for NULL pointers internally so checking
> before calling it is redundant.
>
> Signed-off-by: Jesper Juhl <jj@...osbits.net>
> ---
> drivers/scsi/qla2xxx/qla_os.c |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
> index a2f9992..91b6fe6 100644
> --- a/drivers/scsi/qla2xxx/qla_os.c
> +++ b/drivers/scsi/qla2xxx/qla_os.c
> @@ -4106,8 +4106,7 @@ qla2x00_release_firmware(void)
>
>       mutex_lock(&qla_fw_lock);
>       for (idx = 0; idx < FW_BLOBS; idx++)
> -             if (qla_fw_blobs[idx].fw)
> -                     release_firmware(qla_fw_blobs[idx].fw);
> +             release_firmware(qla_fw_blobs[idx].fw);
>       mutex_unlock(&qla_fw_lock);
> }
>
>

Acked-by: Chad Dupuis <chad.dupuis@...gic.com>

This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this information. If you have received this transmission in error, please notify the sender immediately by reply e-mail and then delete this message.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/