linux-kernel - Re: [PATCH] perf report: fix error with -g in pipe mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F8460C4.4010503@gmail.com>
Date:	Tue, 10 Apr 2012 10:33:08 -0600
From:	David Ahern <dsahern@...il.com>
To:	Stephane Eranian <eranian@...gle.com>, acme@...hat.com
CC:	linux-kernel@...r.kernel.org, mingo@...e.hu, peterz@...radead.org,
	namhyung.kim@....com
Subject: Re: [PATCH] perf report: fix error with -g in pipe mode

On 4/10/12 4:13 AM, Stephane Eranian wrote:
> In pipe mode, we cannot check the validity of sample_type
> or the branch view mode until we start processing the events.
> There is no meta-data information at the beginning of the pipe
> mode stream. Instead, all the meta data is pushed via pseudo
> records and those get processed by process_sample_events().
>
> Without this patch:
>    $ perf record -g -o - foo | perf inject -b | perf report -g -i -
>    Selected -g but no callchain data. Did you call 'perf record' without -g?
>
> Signed-off-by: Stephane Eranian<eranian@...gle.com>

Reviewed-by: David Ahern <dsahern@...il.com>
Tested-by: David Ahern <dsahern@...il.com>


> ---
>
> diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c
> index 2e31743..c338b97 100644
> --- a/tools/perf/builtin-report.c
> +++ b/tools/perf/builtin-report.c
> @@ -249,6 +249,13 @@ static int perf_report__setup_sample_type(struct perf_report *rep)
>   {
>   	struct perf_session *self = rep->session;
>
> +	/*
> +	 * cannot determine sample type, branch mode until we have
> +	 * processed the meta-data pseudo records via process_sample_events()
> +	 */
> +	if (self->fd_pipe)
> +		return 0;
> +
>   	if (!(self->sample_type&  PERF_SAMPLE_CALLCHAIN)) {
>   		if (sort__has_parent) {
>   			ui__warning("Selected --sort parent, but no "

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/