linux-kernel - Re: [PATCH 3/4] arm: davinci: use for_each_set_bit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Wed, 11 Apr 2012 06:02:41 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Christian Riesch <christian.riesch@...cron.at>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
	Sekhar Nori <nsekhar@...com>, Kevin Hilman <khilman@...com>,
	"davinci-linux-open-source@...ux.davincidsp.com" 
	<davinci-linux-open-source@...ux.davincidsp.com>,
	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH 3/4] arm: davinci: use for_each_set_bit_from

2012/4/11 Christian Riesch <christian.riesch@...cron.at>:

>> --- a/arch/arm/mach-davinci/dma.c
>> +++ b/arch/arm/mach-davinci/dma.c
>> @@ -557,9 +557,9 @@ static int reserve_contiguous_slots(int ctlr, unsigned
>> int id,
>>        if (i == edma_cc[ctlr]->num_slots)
>>                stop_slot = i;
>>
>> -       for (j = start_slot; j < stop_slot; j++)
>> -               if (test_bit(j, tmp_inuse))
>> -                       clear_bit(j, edma_cc[ctlr]->edma_inuse);
>> +       j = start_slot;
>> +       for_each_set_bit_from(j, tmp_inuse, stop_slot);
>
> Is the semicolon at the end of the line correct?

It's clearly a bug that I was going to introduce.  I'll fix and
resend it.

Thanks a lot.

>> +               clear_bit(j, edma_cc[ctlr]->edma_inuse);
>>
>>        if (count)
>>                return -EBUSY;
>> --
>> 1.7.4.4
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>> the body of a message to majordomo@...r.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>> Please read the FAQ at  http://www.tux.org/lkml/
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/