| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120410232943.GB5656@tassilo.jf.intel.com> Date: Tue, 10 Apr 2012 16:29:43 -0700 From: Andi Kleen <ak@...ux.intel.com> To: Andrew Morton <akpm@...ux-foundation.org> Cc: Jason Wessel <jason.wessel@...driver.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH][REGRESSION] panic: fix stack dump print on direct call to panic() On Tue, Apr 10, 2012 at 12:19:49PM -0700, Andrew Morton wrote: > On Mon, 09 Apr 2012 11:34:48 -0700 > Andi Kleen <ak@...ux.intel.com> wrote: > > > > The proper way to resolve the problem that original commit tried to > > > solve is to avoid printing a stack dump from panic() when the either > > > of the following conditions is true: > > > > > > 1) TAINT_DIE has been set (this is done by oops_end()) > > > This indicates and oops has already been printed. > > > 2) oops_in_progress> 1 > > > This guards against the rare case where panic() is invoked > > > a second time, or in between oops_begin() and oops_end() > > > > Oops. I guess can just revert it for now. Thanks for catching, Jason. > > You're suggesting a revert of 6e6f0a1f0, but Jason is suggesting that > it be repaired. Confused. Repairing is fine too for me. -Andi -- ak@...ux.intel.com -- Speaking for myself only -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists