linux-kernel - Re: [PATCH 1/2] dma/amba-pl08x: check for terminal count status only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F83AAFD.1030507@st.com>
Date:	Tue, 10 Apr 2012 09:07:33 +0530
From:	Viresh Kumar <viresh.kumar@...com>
To:	Linus Walleij <linus.walleij@...aro.org>
Cc:	Vinod Koul <vinod.koul@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Russell King <linux@....linux.org.uk>,
	Alim Akhtar <alim.akhtar@...il.com>
Subject: Re: [PATCH 1/2] dma/amba-pl08x: check for terminal count status only

On 4/10/2012 2:23 AM, Linus Walleij wrote:
> For some reason I can't figure out we're reading the PL080_INT_STATUS
> register instead of PL080_TC_STATUS when checking for the terminal
> count. The PL080_INT_STATUS is a logical OR between the error and
> terminal count status register and may not report what we want it
> to, especially if there is an error and a terminal count at the same
> time and the former is not lowered in time for the check in the TC
> register. Make sure we read what we're actually interested in.
> 
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Viresh Kumar <viresh.kumar@...com>
> Cc: Alim Akhtar <alim.akhtar@...il.com>
> Signed-off-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/dma/amba-pl08x.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/amba-pl08x.c b/drivers/dma/amba-pl08x.c
> index c301a8e..08589c6 100644
> --- a/drivers/dma/amba-pl08x.c
> +++ b/drivers/dma/amba-pl08x.c
> @@ -1615,7 +1615,7 @@ static irqreturn_t pl08x_irq(int irq, void *dev)
>  			__func__, err);
>  		writel(err, pl08x->base + PL080_ERR_CLEAR);
>  	}
> -	tc = readl(pl08x->base + PL080_INT_STATUS);
> +	tc = readl(pl08x->base + PL080_TC_STATUS);
>  	if (tc)
>  		writel(tc, pl08x->base + PL080_TC_CLEAR);
>  

Acked-by: Viresh Kumar <viresh.kumar@...com>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/