linux-kernel - Re: [PATCH] mmc: pxamci: Use DIV_ROUND

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F83AC80.1070204@st.com>
Date:	Tue, 10 Apr 2012 09:14:00 +0530
From:	Viresh Kumar <viresh.kumar@...com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Ball <cjb@...top.org>,
	Anton Vorontsov <cbouatmailru@...il.com>,
	David Brown <davidb@...eaurora.org>,
	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>
Subject: Re: [PATCH] mmc: pxamci: Use DIV_ROUND_UP at appropriate places

On 4/10/2012 7:30 AM, Axel Lin wrote:
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  drivers/mmc/host/pxamci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c
> index cb2dc0e..4b89e73 100644
> --- a/drivers/mmc/host/pxamci.c
> +++ b/drivers/mmc/host/pxamci.c
> @@ -190,7 +190,7 @@ static void pxamci_setup_data(struct pxamci_host *host, struct mmc_data *data)
>  	clks = (unsigned long long)data->timeout_ns * host->clkrate;
>  	do_div(clks, 1000000000UL);
>  	timeout = (unsigned int)clks + (data->timeout_clks << host->clkrt);
> -	writel((timeout + 255) / 256, host->base + MMC_RDTO);
> +	writel(DIV_ROUND_UP(timeout, 256), host->base + MMC_RDTO);
>  
>  	if (data->flags & MMC_DATA_READ) {
>  		host->dma_dir = DMA_FROM_DEVICE;
> @@ -636,7 +636,7 @@ static int pxamci_probe(struct platform_device *pdev)
>  	/*
>  	 * Calculate minimum clock rate, rounding up.
>  	 */
> -	mmc->f_min = (host->clkrate + 63) / 64;
> +	mmc->f_min = DIV_ROUND_UP(host->clkrate, 64);
>  	mmc->f_max = (mmc_has_26MHz()) ? 26000000 : host->clkrate;
>  
>  	pxamci_init_ocr(host);

Reviewed-by: Viresh Kumar <viresh.kumar@...com>

-- 
viresh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/