linux-kernel - Re: [PATCH] alsa: hide HDMI/ELD printks unless in debug kernels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hty0sunif.wl%tiwai@suse.de>
Date:	Tue, 10 Apr 2012 08:08:56 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Stephen Warren <swarren@...dotorg.org>
Cc:	Fengguang Wu <fengguang.wu@...el.com>, alsa-devel@...a-project.org,
	Nick Bowler <nbowler@...iptictech.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Keith Packard <keithp@...thp.com>
Subject: Re: [PATCH] alsa: hide HDMI/ELD printks unless in debug kernels

At Mon, 09 Apr 2012 09:12:44 -0600,
Stephen Warren wrote:
> 
> On 04/08/2012 08:15 PM, Fengguang Wu wrote:
> > These trivial messages will show up repeatedly on hot plug as well as
> > video mode changes, which could be annoying.
> > 
> > Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>
> 
> Those messages are very useful for end-users to diagnose problems with
> HDMI audio. Is there a way to make the messages dynamic, so users can
> get them if they want, without recompiling their kernel?

We can define a new macro like below, add call like _snd_printd(2,
....) instead of snd_printd().
(Yes, the number 2 can be replaced better in an enum, too.)

In future, we should move to the standard dynamic_printk, but a patch
like this would be a good compromise for merging to 3.4 kernel, IMO.


Takashi

---
diff --git a/include/sound/core.h b/include/sound/core.h
index b6e0f57..442f822 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -354,6 +354,8 @@ void __snd_printk(unsigned int level, const char *file, int line,
  */
 #define snd_printd(fmt, args...) \
 	__snd_printk(1, __FILE__, __LINE__, fmt, ##args)
+#define _snd_printd(level, fmt, args...) \
+	__snd_printk(level, __FILE__, __LINE__, fmt, ##args)
 
 /**
  * snd_BUG - give a BUG warning message and stack trace
@@ -383,6 +385,7 @@ void __snd_printk(unsigned int level, const char *file, int line,
 #else /* !CONFIG_SND_DEBUG */
 
 #define snd_printd(fmt, args...)	do { } while (0)
+#define _snd_printd(level, fmt, args...) do { } while (0)
 #define snd_BUG()			do { } while (0)
 static inline int __snd_bug_on(int cond)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/