linux-kernel - Re: [PATCH 23/26] ALSA: riptide: remove redundant NULL test before release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hmx6kulsw.wl%tiwai@suse.de>
Date:	Tue, 10 Apr 2012 08:45:51 +0200
From:	Takashi Iwai <tiwai@...e.de>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, trivial@...nel.org,
	alsa-devel@...a-project.org, Clemens Ladisch <clemens@...isch.de>,
	Rusty Russell <rusty@...tcorp.com.au>,
	Paul Gortmaker <paul.gortmaker@...driver.com>,
	Jaroslav Kysela <perex@...ex.cz>
Subject: Re: [PATCH 23/26] ALSA: riptide: remove redundant NULL test before release_firmware()

At Mon, 9 Apr 2012 22:52:10 +0200 (CEST),
Jesper Juhl wrote:
> 
> release_firmware() deals gracefully with NULL pointers, no need to check first.
> 
> Signed-off-by: Jesper Juhl <jj@...osbits.net>

Applied now.  Thanks.


Takashi

> ---
>  sound/pci/riptide/riptide.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/sound/pci/riptide/riptide.c b/sound/pci/riptide/riptide.c
> index 0481d94..cbeb3f7 100644
> --- a/sound/pci/riptide/riptide.c
> +++ b/sound/pci/riptide/riptide.c
> @@ -1837,8 +1837,7 @@ static int snd_riptide_free(struct snd_riptide *chip)
>  	}
>  	if (chip->irq >= 0)
>  		free_irq(chip->irq, chip);
> -	if (chip->fw_entry)
> -		release_firmware(chip->fw_entry);
> +	release_firmware(chip->fw_entry);
>  	release_and_free_resource(chip->res_port);
>  	kfree(chip);
>  	return 0;
> -- 
> 1.7.10
> 
> 
> -- 
> Jesper Juhl <jj@...osbits.net>       http://www.chaosbits.net/
> Don't top-post http://www.catb.org/jargon/html/T/top-post.html
> Plain text mails only, please.
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/