linux-kernel - Re: [PATCH 3/4] mfd: Remove redundant spi driver bus initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdZOWWpgoFWYtU4DpLbVGCMRrF+cNLo-m1S2t2Y6xc=YJA@mail.gmail.com>
Date:	Wed, 11 Apr 2012 10:39:07 +0200
From:	Linus Walleij <linus.walleij@...aro.org>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [PATCH 3/4] mfd: Remove redundant spi driver bus initialization

On Tue, Apr 10, 2012 at 10:51 PM, Lars-Peter Clausen <lars@...afoo.de> wrote:

> In ancient times it was necessary to manually initialize the bus field of an
> spi_driver to spi_bus_type. These days this is done in spi_driver_register() so
> we can drop the manual assignment.
>
> The patch was generated using the following coccinelle semantic patch:
> // <smpl>
> @@
> identifier _driver;
> @@
> struct spi_driver _driver = {
>    .driver = {
> -           .bus = &spi_bus_type,
>    },
> };
> // </smpl>
>
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
> Cc: Samuel Ortiz <sameo@...ux.intel.com>
> Cc: Srinidhi Kasagar <srinidhi.kasagar@...ricsson.com>
> Cc: Linus Walleij <linus.walleij@...ricsson.com>

Looks good to me.
Acked-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/