linux-kernel - re: regulator: core: Use a struct to pass in regulator runtime configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20120411090649.GA32589@elgon.mountain>
Date:	Wed, 11 Apr 2012 12:06:49 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	broonie@...nsource.wolfsonmicro.com
Cc:	linux-kernel@...r.kernel.org
Subject: re: regulator: core: Use a struct to pass in regulator runtime
 configuration

Hello Mark Brown,

This is a semi-automatic email about new static checker warnings.

The patch c172708d38a4: "regulator: core: Use a struct to pass in
regulator runtime configuration" from Apr 4, 2012, leads to the
following Smatch complaint:

drivers/regulator/core.c:2860 regulator_register()
	 warn: variable dereferenced before check 'config' (see line 2856)

drivers/regulator/core.c
  2855		struct regulator_dev *rdev;
  2856		struct device *dev = config->dev;
                                     ^^^^^^^^^^^
New dereference.

  2857		int ret, i;
  2858		const char *supply = NULL;
  2859	
  2860		if (regulator_desc == NULL || config == NULL)
                                              ^^^^^^^^^^^^^^
New check.

  2861			return ERR_PTR(-EINVAL);
  2862	

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/