linux-kernel - Re: [PATCH] mmc: remove linux/blkdev.h include from host drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 11 Apr 2012 11:11:57 +0100
From:	Will Newton <will.newton@...il.com>
To:	Dmitry Artamonow <mad_soft@...ox.ru>
Cc:	linux-mmc@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Chris Ball <cjb@...top.org>, linux-kernel@...r.kernel.org,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	Pavel Pisa <ppisa@...ron.com>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Will Newton <will.newton@...tec.com>
Subject: Re: [PATCH] mmc: remove linux/blkdev.h include from host drivers

On Tue, Apr 10, 2012 at 8:06 PM, Dmitry Artamonow <mad_soft@...ox.ru> wrote:
> None of mmc host drivers using linux/blkdev.h header
> really need anything from it. The slight exception is
> atmel-mci, which uses blkdev.h only because it indirectly
> pulls asm/cacheflush.h
>
> So remove any inclusion of blkdev.h - it should also fix
> build errors of dw_mmc and atmel-mci drivers when
> CONFIG_BLOCK is disabled, like following:
> ------------------------------------------------------
> In file included from drivers/mmc/host/dw_mmc.c:14:0:
> include/linux/blkdev.h:1408:42: warning: ‘struct task_struct’ declared inside parameter list [enabled by default]
> include/linux/blkdev.h:1408:42: warning: its scope is only this definition or declaration, which is probably not what you want [enabled by default]
> include/linux/blkdev.h:1412:51: warning: ‘struct task_struct’ declared inside parameter list [enabled by default]
> include/linux/blkdev.h:1417:1: error: unknown type name ‘bool’
> include/linux/blkdev.h:1417:48: warning: ‘struct task_struct’ declared inside parameter list [enabled by default]
> include/linux/blkdev.h: In function ‘blk_needs_flush_plug’:
> include/linux/blkdev.h:1419:9: error: ‘false’ undeclared (first use in this function)
> include/linux/blkdev.h:1419:9: note: each undeclared identifier is reported only once for each function it appears in
> make[1]: *** [drivers/mmc/host/dw_mmc.o] Error 1
> make: *** [drivers/mmc/host/dw_mmc.o] Error 2
> ------------------------------------------------------
>
> Cc: Ludovic Desroches <ludovic.desroches@...el.com>
> Cc: Pavel Pisa <ppisa@...ron.com>
> Cc: Sascha Hauer <s.hauer@...gutronix.de>
> Cc: Will Newton <will.newton@...tec.com>
> Signed-off-by: Dmitry Artamonow <mad_soft@...ox.ru>

For the dw_mmc part:

Acked-by: Will Newton <will.newton@...tec.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/