linux-kernel - Re: [PATCH] virtio_blk: Add help function to format mass of disks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F84DED8.1080800@cn.fujitsu.com>
Date:	Wed, 11 Apr 2012 09:31:04 +0800
From:	Ren Mingxin <renmx@...fujitsu.com>
To:	Asias He <asias@...hat.com>, "Michael S. Tsirkin" <mst@...hat.com>
CC:	Tejun Heo <tj@...nel.org>, axboe@...nel.dk, kvm@...r.kernel.org,
	linux-scsi@...r.kernel.org, asamymuthupa@...ron.com,
	linux-kernel@...r.kernel.org,
	virtualization@...ts.linux-foundation.org,
	James.Bottomley@...senPartnership.com, Avi Kivity <avi@...hat.com>
Subject: Re: [PATCH] virtio_blk: Add help function to format mass of disks

  On 04/11/2012 09:21 AM, Asias He wrote:
> On 04/10/2012 11:53 PM, Michael S. Tsirkin wrote:
>> On Tue, Apr 10, 2012 at 08:49:43AM -0700, Tejun Heo wrote:
>>> Hello, guys.
>>>
>>> On Tue, Apr 10, 2012 at 04:34:06PM +0300, Michael S. Tsirkin wrote:
>>>>> Why not use 'base' below?  neither unit nor base change.
>>>>
>>>> Yes it's a bit strange, it was the same in Tejun's patch.
>>>> Tejun, any idea?
>>>
>>> It was years ago, so I don't recall much.  I think I wanted to use a
>>> variable name which signifies its role - I worked out the rather
>>> convoluted base number logic on paper first and I probably wanted to
>>> keep the distinctions.  I don't think it really matters at this point
>>> tho.  Just make sure those functions are marked deprecated so that no
>>> one else copies them.
>>>
>>> Thanks.
>>
>> I guess I'll keep it same so it's easier to deduplicate
>> if someon wants to.

So, I'd keep this in the next version.

>
> Why not fix it both in sd_format_disk_name() and virtblk_name_format().
> Ren, mind to send v2 to drop the duplicate line?
>

I'll send v2 soon.

-- 
Thanks,
Ren

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/