[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20120411144716.GC16257@infradead.org>
Date: Wed, 11 Apr 2012 11:47:16 -0300
From: Arnaldo Carvalho de Melo <acme@...stprotocols.net>
To: David Ahern <dsahern@...il.com>
Cc: "Nikunj A. Dadhania" <nikunj@...ux.vnet.ibm.com>, mingo@...hat.com,
a.p.zijlstra@...llo.nl, paulus@...ba.org, fweisbec@...il.com,
eranian@...gle.com, linux-kernel@...r.kernel.org
Subject: Re: [BUG PATCH] perf: kvm - finding struct machine fails for
PERF_RECORD_MMAP
Em Tue, Apr 10, 2012 at 09:16:37AM -0600, David Ahern escreveu:
> On 4/9/12 2:22 AM, Nikunj A. Dadhania wrote:
> >Running 'perf kvm --host --guest --guestmount /tmp/guestmount record -a -g -- sleep 2'
> >
> >Was resulting in a segfault. For event type PERF_RECORD_MMAP,
> >event->ip.pid is being used in perf_session__find_machine_for_cpumode,
> >which is not correct.
> >
> >event->ip.pid happens to be 0 in this case and results in returning a
> >NULL machine object. Finally, access to self->pid in
> >machine__mmap_name, results in a segfault later.
> >
> >For PERF_RECORD_MMAP type, pass event->mmap.pid.
>
> Reviewed-by: David Ahern <dsahern@...il.com>
> Tested-by: David Ahern <dsahern@...il.com>
Thanks guys, applied this to my perf/urgent branch.
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists