lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Apr 2012 18:09:09 +0200 From: Juri Lelli <juri.lelli@...il.com> To: Steven Rostedt <rostedt@...dmis.org> CC: Hillf Danton <dhillf@...il.com>, peterz@...radead.org, tglx@...utronix.de, mingo@...hat.com, oleg@...hat.com, fweisbec@...il.com, darren@...art.com, johan.eker@...csson.com, p.faure@...tech.ch, linux-kernel@...r.kernel.org, claudio@...dence.eu.com, michael@...rulasolutions.com, Fabio Checconi <fchecconi@...il.com>, Tommaso Cucinotta <tommaso.cucinotta@...up.it>, Nicola Manica <nicola.manica@...i.unitn.it>, Luca Abeni <luca.abeni@...tn.it>, Dhaval Giani <dhaval.giani@...il.com>, hgu1972@...il.com, paulmck@...ux.vnet.ibm.com, Dario Faggioli <raistlin@...ux.it>, Insop Song <insop.song@...csson.com>, liming.wang@...driver.com Subject: Re: [PATCH 06/16] sched: SCHED_DEADLINE push and pull logic On 04/11/2012 06:00 PM, Steven Rostedt wrote: > On Sun, 2012-04-08 at 22:20 +0200, Juri Lelli wrote: >>> >>>>>> +#ifdef CONFIG_SMP >>>>>> + /* >>>>>> + * In the unlikely case current and p have the same deadline >>>>>> + * let us try to decide what's the best thing to do... >>>>>> + */ >>>>>> + if ((s64)(p->dl.deadline - rq->curr->dl.deadline) == 0&& >>>>>> + !need_resched()) >>>>> >>>>> please recheck !need_resched(), say rq->curr need reschedule? >>>> >>>> Sorry, I don't get this.. >>>> >>> Perhaps smp_processor_id() != rq->cpu >>> >> >> need_resched is actually checked... >> > > I guess what Hillf is trying to say is, > > s/!need_resched()/!test_tsk_need_resched(rq->curr)/ > Yep, I finally got (and changed) it ;-). Thanks, - Juri -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists