linux-kernel - Re: [PATCH 3.3.0] kernel:kfifo: export __kfifo_max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 11 Apr 2012 18:48:59 +0200
From:	Stefani Seibold <stefani@...bold.net>
To:	Srinivas KANDAGATLA <srinivas.kandagatla@...com>
Cc:	mchehab@...radead.org, linux-kernel@...r.kernel.org,
	sfr@...b.auug.org.au
Subject: Re: [PATCH 3.3.0] kernel:kfifo: export __kfifo_max_r symbol.

Locks okay to me.

Acked-by: Stefani Seibold <stefani@...bold.net>

Am Mittwoch, den 11.04.2012, 09:01 +0100 schrieb Srinivas KANDAGATLA:
> From: Srinivas Kandagatla <srinivas.kandagatla@...com>
> 
> kfifo_avail expands to __kfifo_max_r which is not an exported symbol.
> Any kernel module using kfifo_avail will result in build failures
> because of this.
> This patch just exports __kfifo_max_r symbol to fix such problems in
> future.
> 
> This bug was orignially reported by Stephen Rothwell <sfr@...b.auug.org.au> 
> during v4l-dvb tree integration into linux-next.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...com>
> ---
> Hi All, 
> A bulid failure during v4l-dvb tree integration into linux-next shows that __kfifo_max_r symbol is not exported.
> All the __kifo_* functions declared in kfifo.h are already exported symbols.
> I see no reason why __kfifo_max_r should not be exported too.
> 
> comments?
> 
> --srini
> 
>  kernel/kfifo.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/kernel/kfifo.c b/kernel/kfifo.c
> index c744b88..59dcf5b 100644
> --- a/kernel/kfifo.c
> +++ b/kernel/kfifo.c
> @@ -402,6 +402,7 @@ unsigned int __kfifo_max_r(unsigned int len, size_t recsize)
>  		return max;
>  	return len;
>  }
> +EXPORT_SYMBOL(__kfifo_max_r);
>  
>  #define	__KFIFO_PEEK(data, out, mask) \
>  	((data)[(out) & (mask)])


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/