| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20120411185252.GC22543@redhat.com> Date: Wed, 11 Apr 2012 20:52:52 +0200 From: Oleg Nesterov <oleg@...hat.com> To: "Eric W. Biederman" <ebiederm@...ssion.com> Cc: Andrew Morton <akpm@...ux-foundation.org>, David Howells <dhowells@...hat.com>, "Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 1/1] creds: kill __task_cred()->task_is_dead() validation On 04/11, Eric W. Biederman wrote: > > Oleg Nesterov <oleg@...hat.com> writes: > > A small nit. The subject should be: > "Remove task_is_dead from __task_cred() validation." > there is no method __task_cred()->task_is_dead(). I often use this notation to show the caller and the callee, but I don't really mind. > > Unfortunately, we can't kill task_is_dead() right now, it has already > > found the bugy users in drivers/staging/, the fix already exists. > > I would say task_is_dead() has already acquired buggy users in > drivers/staging. Argh, it least I shouldn't have said "bugy". > As for the patch itself, and the direction of removing task_is_dead(). > It looks good from where I sit. > > Reviewed-by: "Eric W. Biederman" <ebiederm@...ssion.com> Thanks! I'll fix the subject/changelog and resend with your and David's acks. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists