linux-kernel - Re: [PATCH 2/2] mmc: Remove dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5D6E9FAF-376B-44A8-89DC-691AC5187FB6@marvell.com>
Date:	Wed, 11 Apr 2012 13:56:39 -0700
From:	Philip Rakity <prakity@...vell.com>
To:	Philippe De Swert <philippedeswert@...il.com>
CC:	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"john.calixto@...systems.com" <john.calixto@...systems.com>,
	"cjb@...top.org" <cjb@...top.org>
Subject: Re: [PATCH 2/2] mmc: Remove dead code


Acked-by: Philip Rakity <prakity@...vell.com>

On Apr 11, 2012, at 1:32 PM, Philippe De Swert wrote:

> bus_width is passed to the function and when 0 (MMC_BUS_WIDTH_1)
> will cause the function to return. So in in the second test it 
> definitly is different from 0, and the third test is redundant.
> 
> Signed-off-by: Philippe De Swert <philippedeswert@...il.com>
> ---
> drivers/mmc/core/mmc.c |    6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
> index 54df5ad..4a1bf8f 100644
> --- a/drivers/mmc/core/mmc.c
> +++ b/drivers/mmc/core/mmc.c
> @@ -556,14 +556,10 @@ static int mmc_compare_ext_csds(struct mmc_card *card, unsigned bus_width)
> 	err = mmc_get_ext_csd(card, &bw_ext_csd);
> 
> 	if (err || bw_ext_csd == NULL) {
> -		if (bus_width != MMC_BUS_WIDTH_1)
> -			err = -EINVAL;
> +		err = -EINVAL;
> 		goto out;
> 	}
> 
> -	if (bus_width == MMC_BUS_WIDTH_1)
> -		goto out;
> -
> 	/* only compare read only fields */
> 	err = !((card->ext_csd.raw_partition_support ==
> 			bw_ext_csd[EXT_CSD_PARTITION_SUPPORT]) &&
> -- 
> 1.7.9.5
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/