linux-kernel - Re: [PATCH v3] Add security.* XATTR support for the UBIFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334214713.13842.34.camel@sauron.fi.intel.com>
Date:	Thu, 12 Apr 2012 10:11:53 +0300
From:	Artem Bityutskiy <dedekind1@...il.com>
To:	subodh.nijsure@...il.com
Cc:	linux-mtd@...ts.infradead.org,
	Adrian Hunter <adrian.hunter@...el.com>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	Subodh Nijsure <snijsure@...d-net.com>
Subject: Re: [PATCH v3] Add security.* XATTR support for the UBIFS

On Wed, 2012-04-11 at 14:28 -0700, subodh.nijsure@...il.com wrote:
> +#ifdef CONFIG_UBIFS_FS_XATTR
> +
> +	err = ubifs_init_security(dir, inode, &dentry->d_name);
> +	if (err) {
> +		ubifs_err("cannot initialize extended attribute, error %d",
> +			  err);
> +		goto out_cancel;
> +	}
> +
> +#endif

Suboodh,

would you please first create a preparational patch which removes
the CONFIG_UBIFS_FS_XATTR completely and makes xattr support to be
always present.

And then you could add the security stuff on top of this without the
#ifdef churn.

Thanks!

-- 
Best Regards,
Artem Bityutskiy

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)