linux-kernel - Re: [PATCH] block: mtip32xx: remove HOTPLUG_PCI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F86865A.3030204@kernel.dk>
Date:	Thu, 12 Apr 2012 09:38:02 +0200
From:	Jens Axboe <axboe@...nel.dk>
To:	Asai Thambi S P <asamymuthupa@...ron.com>
CC:	Greg KH <gregkh@...uxfoundation.org>,
	Sam Bradshaw <sbradshaw@...ron.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: mtip32xx: remove HOTPLUG_PCI_PCIE dependancy

On 04/12/2012 02:46 AM, Asai Thambi S P wrote:
> On 4/11/2012 1:38 PM, Jens Axboe wrote:
> 
>> On 2012-04-11 22:33, Asai Thambi S P wrote:
>>> On 4/11/2012 12:57 PM, Jens Axboe wrote:
>>>
>>>> On 2012-04-11 20:34, Greg KH wrote:
>>>>> This removes the HOTPLUG_PCI_PCIE dependency on the driver and makes it
>>>>> depend on PCI.
>>>>
>>>> I think it's an old dependency. I've built and run it here without as
>>>> well, and no functional issues either.
>>>>
>>>> Sam/Asai?
>>>>
>>>
>>>
>>> Both driver and device will work fine without PCIe hotplug dependency. This
>>> dependency is required for supporting surprise removal and surprise insertion
>>> of the device on systems with PCIe hotplug controller.
>>
>> That goes for all devices, though. So I think we can safely remove this
>> dependency. Nobody should expect hotplug/removal to work, without
>> actually including that :-)
>>
>> If you or Sam would formally ack the patch, then I'll add it to the
>> pending mtip32xx series.
>>
> 
> Acked-by: Asai Thambi S P <asamymuthupa@...ron.com>

Thanks applied Gregs patch - I see the two of you battled it out while I
was sound asleep ;-)

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/