linux-kernel - Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120412075221.GB24833@arwen.pp.htv.fi>
Date:	Thu, 12 Apr 2012 10:52:23 +0300
From:	Felipe Balbi <balbi@...com>
To:	Michal Nazarewicz <mina86@...a86.com>
Cc:	Felipe Balbi <balbi@...com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] usb: gadget: f_mass_storage: remove deprecated fsg_add()

On Wed, Apr 11, 2012 at 09:49:49PM +0200, Michal Nazarewicz wrote:
> >>On Fri, Mar 16, 2012 at 12:25:42PM +0100, Michal Nazarewicz wrote:
> >>>From: Michal Nazarewicz <mina86@...a86.com>
> >>>
> >>>There are no in-tree fsg_add() users and it has been deprecated
> >>>since 2.6.35 [1dc90985d1: fsg_add() renamed to fsg_bind_config()] so
> >>>out-of-tree users had more then enough time to convert.  Removing.
> 
> >On Wed, Apr 11, 2012 at 12:41:13PM +0300, Felipe Balbi wrote:
> >>applied, thanks. Also added your SOB, next time be more careful.
> 
> On Wed, 11 Apr 2012 17:25:28 +0200, Greg Kroah-Hartman <gregkh@...uxfoundation.org> wrote
> >Um, wait, you can't just "add" a SOB, that's not allowed at all, sorry.
> >
> >Michal, do you sign-off on this patch?  If so, please do so.
> 
> Sorry, yes, of course.

I think you need to be more verbose and reply with the actual
Signed-off-by: line

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)