linux-kernel - Re: [PATCH v3] Input: Elan HID-I2C device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Apr 2012 11:10:40 +0200
From:	Benjamin Tissoires <benjamin.tissoires@...il.com>
To:	林彥佑 <tom_lin@....com.tw>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	djkurtz@...omium.org, Jiri Kosina <jkosina@...e.cz>
Subject: Re: [PATCH v3] Input: Elan HID-I2C device driver

Hi Tom,

I read Microsoft's things about HID over I2C few days ago. And from
what I understood, the report descriptors and the enumeration of the
devices are stored in the ACPI table and not in the device itself. Can
you confirm this?

I was thinking about making hid-multitouch independent from the usb
stack and was thinking about doing the i2c-hid bridge. However, I did
not start writing a line yet ;-)

Cheers,
Benjamin

On Thu, Apr 12, 2012 at 03:37, 林彥佑 <tom_lin@....com.tw> wrote:
> Hi Dmitry
>
>
> On 04/12/2012 12:25 AM, Dmitry Torokhov wrote:
>>
>> On Wednesday, April 11, 2012 06:09:03 PM 林彥佑 wrote:
>>>
>>> Hi Daniel
>>>
>>> On 04/11/2012 03:12 PM, Dmitry Torokhov wrote:
>>>>
>>>> Hi Tom,
>>>>
>>>> On Tue, Apr 10, 2012 at 08:42:46PM +0800, Tom Lin wrote:
>>>>>
>>>>> This patch adds driver for Elan I2C touchpad. These protocol of HID-I2C
>>>>> was
>>>>> defined by Microsoft. The kernel driver would use the multi-touch
>>>>> protocol
>>>>> format B.
>>>>
>>>>
>>>> If this device truly supports HID protocol shouldn't we define i2c-hid
>>>> transport, similar to usbhid?
>>>
>>>
>>> I merely follow defined by Microsoft.
>>> It was called "HID OVER I2C" by Microsoft.
>>>
>>> (http://msdn.microsoft.com/en-us/library/windows/hardware/hh825917(v=vs.85).
>>> aspx) But I agree to change from hid i2c to i2chid.
>>> Do you have any better opinions?
>>
>>
>> I am not sure we are talking about same thing... I do not really care
>> whether it is named "hid i2c" or "i2chid". What I meant if the device
>> really speaks HID protocol, except that the transport is not USB or
>> bluetooth but I2C, then instead of writing a custom driver for this
>> particular part we need to add a new HID transport into
>> drivers/hid/i2c-hid that is similar to drivers/hid/usbhid/ and reuse the
>> rest of HID framework along with hid- multitouch.c which handles
>> HID-compliant multitouch devices.
>>
>> I am CCing Jiri (HID maintainer) for additional input.
>
> Sorry! I misunderstood what you mean.
> I fully agree with your suggestion. The I2CHID device will be more and more
> in the future. Need the new i2chid-driver that would cover all hid-compliant
> i2c-devices.
> Thank you
>
> Tom-
>>
>>
>> Thanks.
>>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-input" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/