linux-kernel - Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F86A4EB.4040202@nvidia.com>
Date:	Thu, 12 Apr 2012 15:18:27 +0530
From:	Laxman Dewangan <ldewangan@...dia.com>
To:	Jonathan Cameron <jic23@....ac.uk>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"jbrenner@...sinc.com" <jbrenner@...sinc.com>,
	Rhyland Klein <rklein@...dia.com>, "max@...o.at" <max@...o.at>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH V2 2/2] staging: Documentation: add proximity_sampling_period
 as sysfs details

On Thursday 12 April 2012 03:07 PM, Jonathan Cameron wrote:
> On 4/12/2012 8:08 AM, Laxman Dewangan wrote:
>> +What:		/sys/bus/iio/devices/device[n]/proximity_sampling_period
>> +KernelVersion:	3.5
>> +Contact:	linux-iio@...r.kernel.org
>> +Description:
>> +		Hardware dependent mode for proximity sensor device to set/get
>> +		the sampling rate of proximity sensing and conversion.
> Ah, that explains what it is.  Sorry, use
> in_proximitiy0_sampling_frequency to provide equivalent
> control please.  Might be a pain here, but this interface will just
> provide the same info as the existing
> one in a different form.  Note that sampling_frequency is documented as
> a general one, but can
> be extended to individual channels.
>

Ooop, I did not realize that it is there as part of sysfs.h. I was 
looking for other header to get support for this. I can use this for 
proximity only but I think I should go with you other suggestion to 
implement this on channel basis. This will help also in future for other 
drivers to have different sampling on different channel.
> Actually add it to the iio-core as an element in the info_mask as I
> doubt this will be the last time
> we see this control. This will need to be a precursor patch to the
> driver obviously.
>
> IIO_CHAN_INFO_SAMP_FREQ and the relevant shared and separate macros need
> to go in
> iio.h + the text entry in industrialio-core.c
>
> If you like I can do this but it'll be quicker if you do :)

I will send the patch for implementing this first and then modified 
version of my driver which actually uses this one.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/