linux-kernel - Re: [PATCH V3 1/2] staging: iio: add channel info for sampling frequency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F86D6DF.40704@cam.ac.uk>
Date:	Thu, 12 Apr 2012 14:21:35 +0100
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Laxman Dewangan <ldewangan@...dia.com>
CC:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"grant.likely@...retlab.ca" <grant.likely@...retlab.ca>,
	"rob.herring@...xeda.com" <rob.herring@...xeda.com>,
	"jbrenner@...sinc.com" <jbrenner@...sinc.com>,
	Rhyland Klein <rklein@...dia.com>, "max@...o.at" <max@...o.at>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"devicetree-discuss@...ts.ozlabs.org" 
	<devicetree-discuss@...ts.ozlabs.org>
Subject: Re: [PATCH V3 1/2] staging: iio: add channel info for sampling frequency

On 4/12/2012 2:09 PM, Laxman Dewangan wrote:
> On Thursday 12 April 2012 06:45 PM, Jonathan Cameron wrote:
>> On 4/12/2012 1:38 PM, Laxman Dewangan wrote:
>>> Adding channel info IIO_CHAN_INFO_SAMP_FREQ to select
>>> different sampling frequency per channel wise.
>>>
>>> Signed-off-by: Laxman Dewangan<ldewangan@...dia.com>
>>> ---
>>> As per discussion on previous patch, adding channel info
>>> for selecting sampling freqeuncy.
>> To match with the existing devices can we not use the abrieviation
>> for the attribute naming.
>>
>
> Sorry..I did not get it completely.
> Is it like we should have IIO_CHAN_INFO_SAMPLING_FREQUENCY in place 
> of  IIO_CHAN_INFO_SAMP_FREQ?
SAMP_FREQ is fine internally.
>
>
>>> @@ -90,6 +90,7 @@ static const char * const iio_chan_info_postfix[] = {
>>>        [IIO_CHAN_INFO_AVERAGE_RAW] = "mean_raw",
>>>        [IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY]
>>>        = "filter_low_pass_3db_frequency",
>>> +    [IIO_CHAN_INFO_SAMP_FREQ] = "samp_freq",
>> "sampling_frequency"
>
> and then change here as "sampling_frequency"?
>
Yup, that's the one that is (in the general all channels case) already 
in the abi docs...
>
>
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/