linux-kernel - Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LSU.2.00.1204121049120.2288@eggly.anvils>
Date:	Thu, 12 Apr 2012 10:51:10 -0700 (PDT)
From:	Hugh Dickins <hughd@...gle.com>
To:	Will Deacon <will.deacon@....com>
cc:	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	Nicolas Pitre <nico@...aro.org>
Subject: Re: [PATCH] Revert "proc: clear_refs: do not clear reserved pages"

On Thu, 12 Apr 2012, Will Deacon wrote:

> This reverts commit 85e72aa5384b1a614563ad63257ded0e91d1a620, which was
> a quick fix suitable for -stable until ARM had been moved over to the
> gate_vma mechanism:
> 
> https://lkml.org/lkml/2012/1/14/55
> 
> With commit f9d4861f ("ARM: 7294/1: vectors: use gate_vma for vectors user
> mapping"), ARM does now use the gate_vma, so the PageReserved check can
> be removed from the proc code.
> 
> Cc: Nicolas Pitre <nico@...aro.org>
> Signed-off-by: Will Deacon <will.deacon@....com>

Oh, great, I'm glad that worked out: thanks a lot for looking after it,
Will, and now cleaning up afterwards.

Acked-by: Hugh Dickins <hughd@...gle.com>

> ---
>  fs/proc/task_mmu.c |    3 ---
>  1 files changed, 0 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/proc/task_mmu.c b/fs/proc/task_mmu.c
> index 2b9a760..2d60492 100644
> --- a/fs/proc/task_mmu.c
> +++ b/fs/proc/task_mmu.c
> @@ -597,9 +597,6 @@ static int clear_refs_pte_range(pmd_t *pmd, unsigned long addr,
>  		if (!page)
>  			continue;
>  
> -		if (PageReserved(page))
> -			continue;
> -
>  		/* Clear accessed and referenced bits. */
>  		ptep_test_and_clear_young(vma, addr, pte);
>  		ClearPageReferenced(page);
> -- 
> 1.7.4.1
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/