linux-kernel - Re: [PATCH 6/6] proc: use IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F872322.8040909@gmail.com>
Date:	Thu, 12 Apr 2012 14:46:58 -0400
From:	KOSAKI Motohiro <kosaki.motohiro@...il.com>
To:	Alexey Dobriyan <adobriyan@...il.com>
CC:	Cong Wang <xiyou.wangcong@...il.com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	David Rientjes <rientjes@...gle.com>,
	Hugh Dickins <hughd@...gle.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Siddhesh Poyarekar <siddhesh.poyarekar@...il.com>,
	kosaki.motohiro@...il.com
Subject: Re: [PATCH 6/6] proc: use IS_ERR_OR_NULL()

(4/12/12 9:23 AM), Alexey Dobriyan wrote:
> On Wed, Apr 11, 2012 at 8:59 AM, Cong Wang<xiyou.wangcong@...il.com>  wrote:
>> -       if (mm&&  !IS_ERR(mm)) {
>> +       if (!IS_ERR_OR_NULL(mm)) {
>
> I personally find original code way more readable.

personally, me too. but new one is also acceptable to me.

thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/