linux-kernel - Re: [PATCH 6/6] proc: use IS_ERR_OR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20120412123147.1ac34ae0.akpm@linux-foundation.org>
Date:	Thu, 12 Apr 2012 12:31:47 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Hugh Dickins <hughd@...gle.com>
Cc:	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Cong Wang <xiyou.wangcong@...il.com>,
	linux-kernel@...r.kernel.org, Oleg Nesterov <oleg@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	David Rientjes <rientjes@...gle.com>,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Naoya Horiguchi <n-horiguchi@...jp.nec.com>,
	Siddhesh Poyarekar <siddhesh.poyarekar@...il.com>
Subject: Re: [PATCH 6/6] proc: use IS_ERR_OR_NULL()

On Thu, 12 Apr 2012 12:26:51 -0700 (PDT)
Hugh Dickins <hughd@...gle.com> wrote:

> On Thu, 12 Apr 2012, KOSAKI Motohiro wrote:
> > (4/12/12 9:23 AM), Alexey Dobriyan wrote:
> > > On Wed, Apr 11, 2012 at 8:59 AM, Cong Wang<xiyou.wangcong@...il.com>
> > > wrote:
> > > > -       if (mm&&  !IS_ERR(mm)) {
> > > > +       if (!IS_ERR_OR_NULL(mm)) {
> > > 
> > > I personally find original code way more readable.
> > 
> > personally, me too. but new one is also acceptable to me.
> 
> That now makes 4 votes that it's not an improvement, with no dissent
> (unless akpm's + proc-use-is_err_or_null.patch added to -mm tree
> should be counted as dissent): let's drop this patch.

I think it's OK.  IS_ERR_OR_NULL encapsulates the concept "something
went wrong".

Not that I'm particularly passionate about it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/