linux-kernel - Re: [PATCH] stack usage: Add pid to warning printk in check_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120412215002.GA31852@redhat.com>
Date:	Thu, 12 Apr 2012 23:50:02 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Tim Bird <tim.bird@...sony.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andrea Arcangeli <andrea@...e.de>,
	Frederic Weisbecker <fweisbec@...il.com>,
	linux kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] stack usage: Add pid to warning printk in
	check_stack_usage

On 04/11, Tim Bird wrote:
>
> In embedded systems, sometimes the same program (busybox)
> is the cause of multiple warnings.  Outputting the pid
> with the program name in the warning printk helps
> distinguish which instances of a program are using
> the stack most.
>
> This is a small patch, but useful.

Agreed, pid_nr alone is useless if you read the logs when this
app has already terminated.

> Signed-off-by: Tim Bird <tim.bird@...sony.com>
> ---
>  exit.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/kernel/exit.c b/kernel/exit.c
> index b8a6a09..bad923d 100644
> --- a/kernel/exit.c
> +++ b/kernel/exit.c
> @@ -898,9 +898,9 @@ static void check_stack_usage(void)
> 
>  	spin_lock(&low_water_lock);
>  	if (free < lowest_to_date) {
> -		printk(KERN_WARNING "%s used greatest stack depth: %lu bytes "
> -				"left\n",
> -				current->comm, free);
> +		printk(KERN_WARNING "%s (%d) used greatest stack depth: "
> +				"%lu bytes left\n",
> +				current->comm, task_pid_nr(current), free);
>  		lowest_to_date = free;
>  	}
>  	spin_unlock(&low_water_lock);
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/