linux-kernel - Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120412230058.GA23292@kroah.com>
Date:	Thu, 12 Apr 2012 16:00:58 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	zhangyanfei <zhangyanfei@...fujitsu.com>
Cc:	avi@...hat.com, mtosatti@...hat.com, ebiederm@...ssion.com,
	luto@....edu, joerg.roedel@....com, dzickus@...hat.com,
	paul.gortmaker@...driver.com, gregkh@...e.de,
	ludwig.nussel@...e.de, linux-kernel@...r.kernel.org,
	kvm@...r.kernel.org, kexec@...ts.infradead.org
Subject: Re: [PATCH 3/4] ksysfs: export VMCSINFO via sysfs

On Wed, Apr 11, 2012 at 09:57:34AM +0800, zhangyanfei wrote:
> This patch creates sysfs file to export where VMCSINFO is allocated,
> as below:
>         $ cat /sys/kernel/vmcsinfo
>         1cb88a0 2000
> number on the left-hand side is the physical address of VMCSINFO,
> while the one on the right-hand side is the max size of VMCSINFO.

Ick, why do you have 2 values in one sysfs file, that's not nice, or
good.

What's wrong with 2 different files?

Also, any new sysfs file you add needs to also have a Documentation/ABI
entry added as well.

But we can't accept this as-is, sorry, please split it up into 2 files.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/