linux-kernel - Re: [PATCH] video: pxa3xx-gcu: Simplify the logic to exit while loop in pxa3xx_gcu_wait

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Apr 2012 02:22:11 +0000
From:	Florian Tobias Schandinat <FlorianSchandinat@....de>
To:	Axel Lin <axel.lin@...il.com>
CC:	linux-kernel@...r.kernel.org, Daniel Mack <daniel@...aq.de>,
	Sven Neumann <s.neumann@...mfeld.com>,
	Janine Kropp <nin@...ectfb.org>,
	Denis Oliver Kropp <dok@...ectfb.org>,
	linux-fbdev@...r.kernel.org
Subject: Re: [PATCH] video: pxa3xx-gcu: Simplify the logic to exit while loop
 in pxa3xx_gcu_wait_idle

On 03/27/2012 03:15 AM, Axel Lin wrote:
> If wait_event_interruptible_timeout returns a positive value, it means
> the condition evaluated is true. Which means priv->shared->hw_running is false.
> And then we will exit the loop.
> 
> This patch simplifies the logic to exit the while loop.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/pxa3xx-gcu.c |    5 +----
>  1 files changed, 1 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/pxa3xx-gcu.c b/drivers/video/pxa3xx-gcu.c
> index 1d71c08..0b4ae0c 100644
> --- a/drivers/video/pxa3xx-gcu.c
> +++ b/drivers/video/pxa3xx-gcu.c
> @@ -316,12 +316,9 @@ pxa3xx_gcu_wait_idle(struct pxa3xx_gcu_priv *priv)
>  		ret = wait_event_interruptible_timeout(priv->wait_idle,
>  					!priv->shared->hw_running, HZ*4);
>  
> -		if (ret < 0)
> +		if (ret != 0)
>  			break;
>  
> -		if (ret > 0)
> -			continue;
> -
>  		if (gc_readl(priv, REG_GCRBEXHR) == rbexhr &&
>  		    priv->shared->num_interrupts == num) {
>  			QERROR("TIMEOUT");

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/