linux-kernel - Re: [PATCH RFT 1/3] regulator: ab3100: Add dummy set_suspend_[enable|disable] callbacks implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120413081607.GA3168@opensource.wolfsonmicro.com>
Date:	Fri, 13 Apr 2012 09:16:07 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Linus Walleij <linus.walleij@...ricsson.com>,
	Liam Girdwood <lrg@...com>
Subject: Re: [PATCH RFT 1/3] regulator: ab3100: Add dummy
 set_suspend_[enable|disable] callbacks implementation

On Fri, Apr 13, 2012 at 12:41:38PM +0800, Axel Lin wrote:
> Without the implementation of set_suspend_enable and set_suspend_disable callbacks,
> the regulator core won't call set_suspend_voltage.
> 
> Thus add dummy implementation for set_suspend_[enable|disable] callbacks.

No, if we need to go adding dummy functions to a bunch of drivers we're
clearly going about things the wrong way and should be avoiding the need
to have those functions in the first place.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)