linux-kernel - Re: [PATCH] ASoC: cs42l73: don't use negative array index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120413090200.GI3168@opensource.wolfsonmicro.com>
Date:	Fri, 13 Apr 2012 10:02:00 +0100
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jesper Juhl <jj@...osbits.net>
Cc:	linux-kernel@...r.kernel.org, alsa-devel@...a-project.org,
	Vinod Koul <vinod.koul@...ux.intel.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Brian Austin <brian.austin@...rus.com>,
	Axel Lin <axel.lin@...il.com>, Takashi Iwai <tiwai@...e.de>,
	Jaroslav Kysela <perex@...ex.cz>, Liam Girdwood <lrg@...com>,
	joe@...leusys.com
Subject: Re: [PATCH] ASoC: cs42l73: don't use negative array index

On Thu, Apr 12, 2012 at 09:54:34PM +0200, Jesper Juhl wrote:
> If cs42l73_get_mclkx_coeff() returns < 0 (which it can) in
> sound/soc/codecs/cs42l73.c::cs42l73_set_mclk(), then we'll be using
> the (negative) return value as array index on the very next line of
> code - that's bad.

Applied, thanks.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)