linux-kernel - Re: [PATCH] rtc: tegra: cleanup probe/remove routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120413125405.GA5952@beyadr.localdomain>
Date:	Fri, 13 Apr 2012 15:54:05 +0300
From:	Hannu Heikkinen <hannuxx@....fi>
To:	Venu Byravarasu <vbyravarasu@...dia.com>
Cc:	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>
Subject: Re: [PATCH] rtc: tegra: cleanup probe/remove routines

On 13/04/12 11:05 +0530, Venu Byravarasu wrote:
> > +	if (info->tegra_rtc_irq <= 0)
> > +		return -EBUSY;
> Interrupt support is needed only for wake up or timer support.
> Apart from them RTC can be used for reference time keeping.
> 
> So, is it not good to print a warn message as "wake up
> with alarm is not supported" and proceed further instead of 
> returning failure from the driver itself?

I propose that this patch would go in as is, as this is mainly for adjusting 
probe/remove routines for using devm_* funcs, and to leave that above issue
you mentioned to another patch, as it would be a change to current behavior.


br,
Hannu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/