linux-kernel - RE: Patch "USB: serial: mos7840: Supported MCS7810 device"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <002701cd191c$1077d580$31678080$@com.tw>
Date:	Fri, 13 Apr 2012 10:20:52 +0800
From:	"Donald" <donald@...x.com.tw>
To:	"'Alan Cox'" <alan@...rguk.ukuu.org.uk>
Cc:	"'Greg KH'" <gregkh@...uxfoundation.org>,
	"'open list:USB SUBSYSTEM'" <linux-usb@...r.kernel.org>,
	"'open list'" <linux-kernel@...r.kernel.org>
Subject: RE: Patch "USB: serial: mos7840: Supported MCS7810 device"

Hi Alan,

Thank you for your reply. As for your comment regarding the LED feature flag, the driver can provide a flag parameter for LED
feature so that users will be able to set this LED feature at loading the driver, and by default, this flag is set false (LED
feature is disabled). Could you let me know if this is what exactly matches your comment?

Regards,
Donald

-----Original Message-----
From: Alan Cox [mailto:alan@...rguk.ukuu.org.uk] 
Sent: Thursday, April 12, 2012 5:50 PM
To: Donald
Cc: 'Greg KH'; 'open list:USB SUBSYSTEM'; 'open list'
Subject: Re: Patch "USB: serial: mos7840: Supported MCS7810 device"

> +/* MCS7810 LED support */
> +#define MCS7810_HAS_LED

I would just enable this. Nobody is going to change it in their source code.


> +#ifdef MCS7810_HAS_LED
> +	/* Turn on MCS7810 LED */
> +	if (serial->num_ports == 1 && mos7840_port->mos7810_led_flag == 0) {

Same comment as before about leds and flags to indicate features.

All these if cases should be a feature flag of some kind

Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/