linux-kernel - Re: [PATCH 1/2] drm/nouveau: Add lock on drm_helper_resume_force

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 14 Apr 2012 02:59:32 +0200
From:	Peter Hüwe <PeterHuewe@....de>
To:	Jonathan Nieder <jrnieder@...il.com>
Cc:	David Airlie <airlied@...ux.ie>, Ben Skeggs <bskeggs@...hat.com>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	Dave Airlie <airlied@...hat.com>,
	Alex Deucher <alexander.deucher@....com>,
	Jerome Glisse <jglisse@...hat.com>,
	Christian König <deathsimple@...afone.de>,
	Michel Dänzer <michel.daenzer@....com>,
	dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
	stable@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 1/2] drm/nouveau: Add lock on drm_helper_resume_force_mode

Am Samstag 14 April 2012, 02:52:19 schrieb Jonathan Nieder:
> Hi,
> 
> Peter Huewe wrote:
> > mode_config should be locked when calling drm_helper_resume_force_mode.
> > This patch adds the lock, similar to #927a2f119.
> 
> Does this fix a problem that has been observed in the wild, or only a
> theoretical one?
> 
> Curious,
> Jonathan

Only theoretical ;)
Since all other drivers always lock around drm_helper_resume_force_mode I 
guessed this is good practice.

And since problem area is quite similar to the one mentioned in #927a2f119 / 
234f78a683e 
http://git.kernel.org/?p=linux/kernel/git/stable/linux-
stable.git;a=commit;h=234f78a683e30d6d4628846fde4a822c0e385529
the bug might happen in the wild.


Thanks,
Peter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/