linux-kernel - Re: [PATCH] hfsplus: Fix bless ioctl when used with hardlinks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4F896787.4050108@gmail.com>
Date:	Sat, 14 Apr 2012 14:03:19 +0200
From:	Marco Stornelli <marco.stornelli@...il.com>
To:	Matthew Garrett <mjg@...hat.com>
CC:	hch@...radead.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hfsplus: Fix bless ioctl when used with hardlinks

Il 13/04/2012 16:06, Matthew Garrett ha scritto:
> HFS+ doesn't really implement hard links - instead, hardlinks are indicated
> by a magic file type which refers to an indirect node in a hidden
> directory. The spec indicates that stat() should return the inode number
> of the indirect node, but it turns out that this doesn't satisfy the
> firmware when it's looking for a bootloader - it wants the catalog ID of
> the hardlink file instead. Fix up this case.
>
> Signed-off-by: Matthew Garrett<mjg@...hat.com>
> ---
>   fs/hfsplus/ioctl.c |    9 +++++++--
>   1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/fs/hfsplus/ioctl.c b/fs/hfsplus/ioctl.c
> index c640ba5..5ee0681 100644
> --- a/fs/hfsplus/ioctl.c
> +++ b/fs/hfsplus/ioctl.c
> @@ -31,6 +31,7 @@ static int hfsplus_ioctl_bless(struct file *file, int __user *user_flags)
>   	struct hfsplus_sb_info *sbi = HFSPLUS_SB(inode->i_sb);
>   	struct hfsplus_vh *vh = sbi->s_vhdr;
>   	struct hfsplus_vh *bvh = sbi->s_backup_vhdr;
> +	int cnid = (u32)(unsigned long)dentry->d_fsdata;
>

Why a double cast?

Marco
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/