linux-kernel - Re: [PATCH] m68k: Make sure {read,write}s[bwl]() are always defined

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 12:30:30 +0300
From:	Felipe Balbi <balbi@...com>
To:	Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:	linux-m68k@...r.kernel.org, Felipe Balbi <balbi@...com>,
	Greg Ungerer <gerg@...inux.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH] m68k: Make sure {read,write}s[bwl]() are always defined

On Sun, Apr 15, 2012 at 09:00:10PM +0200, Geert Uytterhoeven wrote:
> If CONFIG_ATARI_ROM_ISA is defined (e.g. allmodconfig), musb fails to
> compile with:
> 
> In file included from drivers/usb/musb/musb_core.h:68,
>                  from drivers/usb/musb/musb_core.c:104:
> drivers/usb/musb/musb_io.h:45: error: conflicting types for ‘raw_insl’
> arch/m68k/include/asm/raw_io.h:200: error: previous definition of ‘raw_insl’ was here
> drivers/usb/musb/musb_io.h:47: error: conflicting types for ‘raw_insw’
> arch/m68k/include/asm/raw_io.h:121: error: previous definition of ‘raw_insw’ was here
> drivers/usb/musb/musb_io.h:52: error: conflicting types for ‘raw_outsl’
> arch/m68k/include/asm/raw_io.h:240: error: previous definition of ‘raw_outsl’ was here
> drivers/usb/musb/musb_io.h:54: error: conflicting types for ‘raw_outsw’
> arch/m68k/include/asm/raw_io.h:161: error: previous definition of ‘raw_outsw’ was here
> make[4]: *** [drivers/usb/musb/musb_core.o] Error 1
> 
> This happens because musb_io.h provides default implementations for
> {read,write}s[bwl]() on most platforms, some of which conflict with their
> Atari ROM ISA counterparts.
> 
> To avoid adding a check for CONFIG_ATARI_ROM_ISA to musb_io.h, make sure
> {read,write}s[bwl]() are always defined on m68k, and disable the default
> implementations in musb_io.h on m68k, like is already done for several
> other architectures.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> Cc: Felipe Balbi <balbi@...com>
> Cc: Greg Ungerer <gerg@...inux.org>

Go ahea Geert, here's my ack.

Acked-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)