linux-kernel - RE: [PATCH] rtc: tegra: cleanup probe/remove routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <D958900912E20642BCBC71664EFECE3E6DD6758822@BGMAIL02.nvidia.com>
Date:	Mon, 16 Apr 2012 08:51:51 +0530
From:	Venu Byravarasu <vbyravarasu@...dia.com>
To:	Hannu Heikkinen <hannuxx@....fi>
CC:	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"a.zummo@...ertech.it" <a.zummo@...ertech.it>
Subject: RE: [PATCH] rtc: tegra: cleanup probe/remove routines

Should be fine.

> -----Original Message-----
> From: Hannu Heikkinen [mailto:hannuxx@....fi]
> Sent: Friday, April 13, 2012 6:24 PM
> To: Venu Byravarasu
> Cc: rtc-linux@...glegroups.com; linux-kernel@...r.kernel.org;
> a.zummo@...ertech.it
> Subject: Re: [PATCH] rtc: tegra: cleanup probe/remove routines
> 
> On 13/04/12 11:05 +0530, Venu Byravarasu wrote:
> > > +	if (info->tegra_rtc_irq <= 0)
> > > +		return -EBUSY;
> > Interrupt support is needed only for wake up or timer support.
> > Apart from them RTC can be used for reference time keeping.
> >
> > So, is it not good to print a warn message as "wake up
> > with alarm is not supported" and proceed further instead of
> > returning failure from the driver itself?
> 
> I propose that this patch would go in as is, as this is mainly for adjusting
> probe/remove routines for using devm_* funcs, and to leave that above issue
> you mentioned to another patch, as it would be a change to current behavior.
> 
> 
> br,
> Hannu

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/