linux-kernel - Re: [PATCH] fs/btrfs/volumes.c: add missing free_fs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20120416140207.GB20982@twin.jikos.cz>
Date:	Mon, 16 Apr 2012 16:02:07 +0200
From:	David Sterba <dave@...os.cz>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	Chris Mason <chris.mason@...cle.com>,
	kernel-janitors@...r.kernel.org, linux-btrfs@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/btrfs/volumes.c: add missing free_fs_devices

On Sat, Apr 14, 2012 at 11:24:33AM +0200, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>
> 
> Free fs_devices as done in the error-handling code just below.
> 
> Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> 
> ---
>  fs/btrfs/volumes.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/btrfs/volumes.c b/fs/btrfs/volumes.c
> index a872b48..5d246c3 100644
> --- a/fs/btrfs/volumes.c
> +++ b/fs/btrfs/volumes.c
> @@ -4334,8 +4334,10 @@ static int open_seed_devices(struct btrfs_root *root, u8 *fsid)
>  
>  	ret = __btrfs_open_devices(fs_devices, FMODE_READ,
>  				   root->fs_info->bdev_holder);
> -	if (ret)
> +	if (ret) {
> +		free_fs_devices(fs_devices);
>  		goto out;
> +	}
>  
>  	if (!fs_devices->seeding) {
>  		__btrfs_close_devices(fs_devices);

Reviewed-by: David Sterba <dsterba@...e.cz>

thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/