linux-kernel - Re: kvm: RCU warning in async pf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20120416141735.GA18613@redhat.com>
Date:	Mon, 16 Apr 2012 17:17:35 +0300
From:	Gleb Natapov <gleb@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Sasha Levin <levinsasha928@...il.com>, Avi Kivity <avi@...hat.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>,
	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>,
	kvm <kvm@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: kvm: RCU warning in async pf

On Mon, Apr 16, 2012 at 03:27:20PM +0200, Peter Zijlstra wrote:
> On Mon, 2012-04-16 at 15:18 +0200, Peter Zijlstra wrote:
> > On Mon, 2012-04-16 at 16:08 +0300, Gleb Natapov wrote:
> > > On Mon, Apr 16, 2012 at 03:05:48PM +0200, Peter Zijlstra wrote:
> > > > On Mon, 2012-04-16 at 15:58 +0300, Gleb Natapov wrote:
> > > > > -               rcu_irq_enter();
> > > > > +               irq_enter();
> > > > >                 exit_idle(); 
> > > > 
> > > > Do we really need the exit_idle()? I can't remember other interrupt
> > > > handlers doing that.
> > > They do. That's where I got the idea.
> > 
> > Some do.. some don't.. /me goes have a look what this exit_idle nonsense
> > is all about. Looks to be something broken.
> 
> Yeah, its broken and the whole implementation is crap anyway. There's
> only one user (drivers/idle/i7300_idle.c) so it likely doesn't matter
> (much) anyway.
> 
Should I resend the patch with removal of exit_idle() call or it will
be removed by a patch that removes exit_idle() completely later?

> Thomas, can we rip that stuff out? or do we have to like actually fix
> it?

--
			Gleb.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/