linux-kernel - Re: [PATCH 2/6] uprobes: introduce is_swbp_at_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1334588109.28150.59.camel@twins>
Date:	Mon, 16 Apr 2012 16:55:09 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	Ingo Molnar <mingo@...e.hu>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ananth N Mavinakayanahalli <ananth@...ibm.com>,
	Jim Keniston <jkenisto@...ux.vnet.ibm.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Linux-mm <linux-mm@...ck.org>, Andi Kleen <andi@...stfloor.org>,
	Christoph Hellwig <hch@...radead.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Anton Arapov <anton@...hat.com>
Subject: Re: [PATCH 2/6] uprobes: introduce is_swbp_at_addr_fast()

On Mon, 2012-04-16 at 16:44 +0200, Oleg Nesterov wrote:
> On 04/16, Peter Zijlstra wrote:
> >
> > On Fri, 2012-04-06 at 00:21 +0200, Oleg Nesterov wrote:
> > > +int __weak is_swbp_at_addr_fast(unsigned long vaddr)
> > > +{
> > > +       uprobe_opcode_t opcode;
> > > +       int fault;
> > > +
> > > +       pagefault_disable();
> > > +       fault = __copy_from_user_inatomic(&opcode, (void __user*)vaddr,
> > > +                                                       sizeof(opcode));
> > > +       pagefault_enable();
> > > +
> > > +       if (unlikely(fault)) {
> > > +               /*
> > > +                * XXX: read_opcode() lacks FOLL_FORCE, it can fail if
> > > +                * we race with another thread which does mprotect(NONE)
> > > +                * after we hit bp.
> > > +                */
> > > +               if (read_opcode(current->mm, vaddr, &opcode))
> > > +                       return -EFAULT;
> > > +       }
> > > +
> > > +       return is_swbp_insn(&opcode);
> > > +}
> >
> > Why bother with the pagefault_disable() and unlikely fault case and not
> > simply do copy_from_user() and have it deal with the fault if its needed
> > anyway?
> 
> But we can't do this under down_read(mmap_sem) ?
> 
> If another thread waits for down_write() then do_page_fault() can't take
> this lock, right?

Ah, indeed, I thought read_opcode() would do the fault, but that's
get_user_pages() which requires the caller to hold mmap_sem instead.

Can't we 'optimize' read_opcode() by doing the pagefault_disable() +
__copy_from_user_inatomic() optimistically before going down the whole
gup()+lock+kmap path?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/