linux-kernel - Re: [PATCH v2 07/16] KVM: MMU: introduce for_each_pte_list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8B93B9.2030801@linux.vnet.ibm.com>
Date:	Mon, 16 Apr 2012 11:36:25 +0800
From:	Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com>
To:	Takuya Yoshikawa <takuya.yoshikawa@...il.com>
CC:	Avi Kivity <avi@...hat.com>, Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, KVM <kvm@...r.kernel.org>
Subject: Re: [PATCH v2 07/16] KVM: MMU: introduce for_each_pte_list_spte

On 04/14/2012 10:44 AM, Takuya Yoshikawa wrote:

> On Fri, 13 Apr 2012 18:12:41 +0800b
> Xiao Guangrong <xiaoguangrong@...ux.vnet.ibm.com> wrote:
> 
>> It is used to walk all the sptes of the specified pte_list, after
>> this, the code of pte_list_walk can be removed
>>
>> And it can restart the walking automatically if the spte is zapped
> 
> Well, I want to ask two questions:
> 
> 	- why do you prefer pte_list_* naming to rmap_*?
> 	  (not a big issue but just curious)


pte_list is a common infrastructure for both parent-list and rmap.

> 	- Are you sure the whole indirection by this patch will
> 	  not introduce any regression?
> 	  (not restricted to get_dirty)
> 


I tested it with kernbench, no regression is found.

It is not a problem since the iter and spte should be in the cache.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/