linux-kernel - [REGRESSION] rtc/interface.c: kills suspend-to-ram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4F8BA1C1.4030804@teksavvy.com>
Date:	Mon, 16 Apr 2012 00:36:17 -0400
From:	Mark Lord <kernel@...savvy.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>,
	rtc-linux@...glegroups.com,
	Alessandro Zummo <a.zummo@...ertech.it>,
	Greg Kroah-Hartman <greg@...ah.com>, stable@...r.kernel.org
Subject: [REGRESSION] rtc/interface.c: kills suspend-to-ram

Something recent has killed suspend-to-ram on a number of machines here.
The symptom is that they suspend, but immediately wake up and panic,
with just a black screen so no visible messages to go by.

The patch below works around the issue -- making things work as they used to work.

--- linux/drivers/rtc/interface.c.orig	2012-04-16 00:08:47.615389718 -0400
+++ linux/drivers/rtc/interface.c	2012-04-16 00:09:14.105387382 -0400
@@ -773,7 +773,7 @@
 	if (!rtc->ops || !rtc->ops->alarm_irq_enable)
 		return;

-	rtc->ops->alarm_irq_enable(rtc->dev.parent, false);
+	//rtc->ops->alarm_irq_enable(rtc->dev.parent, false);  // Kills suspend on ZBOX HD-ID41U
 }

 /**

Last known working kernel was 3.2.11.
The line above got added somewhere between it and 3.2.15,
and is also present (no surprise) in newer kernels.

The highest kernel I've tested for this is 3.3.2,
which also fails until I nuke the line shown above.

This is straight x86_64 (Atom) hardware, using rtc-cmos.
I can re-test if anyone has a fix for this.

Meanwhile, whatever patch put this into -stable probably
ought to be reverted upstream and in -stable as well.

Cheers

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/