linux-kernel - RE: [PATCH 1/1] lpc_sch: Add Intel Centerton Multifunction Device support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 16 Apr 2012 16:42:41 +0000
From:	"Heasley, Seth" <seth.heasley@...el.com>
To:	Samuel Ortiz <sameo@...ux.intel.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Ralston, James D" <james.d.ralston@...el.com>
Subject: RE: [PATCH 1/1] lpc_sch: Add Intel Centerton Multifunction Device
 support

Hi Samuel,

>>
>> +#define PCI_DEVICE_ID_INTEL_CENTERTON_ILB	0x0c60
>> +
>So we're not going to need this ID anywhere else ? In the GPIO driver
>for example ?
>If we do need it there, this ID should move to pci_ids.h

Actually, it looks like the GPIO driver *will* need it, so I'll go ahead and move it to pci_ids.h since it's used in more than one driver.

>>  static struct resource smbus_sch_resource = {
>>  		.flags = IORESOURCE_IO,
>>  };
>> @@ -68,7 +71,7 @@ static struct resource wdt_sch_resource = {
>>
>>  static struct mfd_cell tunnelcreek_cells[] = {
>>  	{
>> -		.name = "tunnelcreek_wdt",
>> +		.name = "ie6xx_wdt",
>What do we need this change for ?

As mentioned in a previous email, the wdt driver is being renamed, so I'm reflecting that here.

I'll make a couple of changes and resubmit.

Regards,
-Seth
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/